[AMD] Add ROCm latest tags to AMD Docker release workflow#14380
Closed
quitenode wants to merge 3 commits intosgl-project:mainfrom
Closed
[AMD] Add ROCm latest tags to AMD Docker release workflow#14380quitenode wants to merge 3 commits intosgl-project:mainfrom
quitenode wants to merge 3 commits intosgl-project:mainfrom
Conversation
This adds a new job 'create-rocm-latest-tags' that runs after the 'publish' job and creates floating 'latest' tags for ROCm images: - lmsysorg/sglang:rocm-latest (points to rocm700-mi30x) - lmsysorg/sglang:rocm630-mi30x-latest - lmsysorg/sglang:rocm700-mi30x-latest - lmsysorg/sglang:rocm700-mi35x-latest This allows users to simply run 'docker pull lmsysorg/sglang:rocm-latest' instead of having to look up the specific versioned tag.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
quitenode
changed the title
quitenode
requested review from
Fridge003,
Kangyan-Zhou,
ispobock and
merrymercy
as code owners
Collaborator
|
@saienduri Please review the added chunk of handling code - rocm700-mi35x-latest -> v0.5.6.post1-rocm700-mi35x-20251209 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This adds a new job 'create-rocm-latest-tags' that runs after the 'publish' job and creates floating 'latest' tags for ROCm images:
This allows users to simply run 'docker pull lmsysorg/sglang:rocm-latest' instead of having to look up the specific versioned tag.
CC: @HaiShaw, @saienduri
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist